Merged
Conversation
brenzi
commented
Sep 15, 2023
Comment on lines
+57
to
+58
| log::info!( | ||
| "teerexV1: {} v0 enclaves are present before eventual upgrade", |
Contributor
Author
There was a problem hiding this comment.
the log target gets swallowed by try-runtime. therefore using prefix in log msg
Contributor
There was a problem hiding this comment.
How do they do it in substrate? Like this, it will probably be displayed in try-runtime, but actually not be logged in production.
clangenb
approved these changes
Sep 15, 2023
Contributor
clangenb
left a comment
There was a problem hiding this comment.
One question about the logging. LGTM otherwise.
Comment on lines
+57
to
+58
| log::info!( | ||
| "teerexV1: {} v0 enclaves are present before eventual upgrade", |
Contributor
There was a problem hiding this comment.
How do they do it in substrate? Like this, it will probably be displayed in try-runtime, but actually not be logged in production.
Contributor
Author
|
good point. it will be logged for sure, but our log filtering might miss it. I'll re-add the target so we double-mention teerex |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tested against rococo and kusama: