accept any new sidechain block from authorized enclave for shard#236
Merged
accept any new sidechain block from authorized enclave for shard#236
Conversation
clangenb
approved these changes
Dec 22, 2023
Contributor
clangenb
left a comment
There was a problem hiding this comment.
Hmm, I see the point of avoiding forks by choosing which validateer is authorized to have its blocks finalized, and we can already say that having a round robing scheme for this authorization, we kind of ensure quick finality, if we don't have many validateers.
Might have been overengineered before.
This was referenced Dec 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #235
the previous logic where validateers had to announce their next block to be expected was too brittle and had no effective security benefit. All we need is:
avoiding forks is still the naive solution: just finalize blocks from the first validateer appearing in the ShardStatus, which usually is the primary validateer who created the shard