Skip to content

Invalid Justification handling #366

@haerdib

Description

@haerdib

With PR #365 an error will be printed upon an encountering an invalid justification instead of returning an error (and ending up in an endless loop of trying to import the block with the faulty justification , see issue #353).

However, this is only a temporary solution. Substrate handles bad justifcations alittle bit more complex: if the block enforces a justification ( needs_justification = true ) a justification is rerequest from other peers: https://github.com/paritytech/substrate/blob/master/client/finality-grandpa/src/import.rs#L642-L646

Should the worker handle this case in a similar way?

Metadata

Metadata

Assignees

No one assigned

    Labels

    F9-questionFurther information is requestedS5-LightClientParentchain Component

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions