read registers before calculating pll clock#28
Open
wose wants to merge 1 commit intointel-retail:mainfrom
Open
read registers before calculating pll clock#28wose wants to merge 1 commit intointel-retail:mainfrom
wose wants to merge 1 commit intointel-retail:mainfrom
Conversation
wose
force-pushed
the
fix-get-pll-clock-xe
branch
from
c23957a to
fb81177
Compare
get_pll_clock always returned 0.0 on devices running the xe driver. Initializing the register state by calling read_register before calculating the clock fixes this.
wose
force-pushed
the
fix-get-pll-clock-xe
branch
from
fb81177 to
1adf4f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were trying to use the library on devices with Arrow Lake-S GPU running linux 6.18 and the Xe driver. The call to
get_pll_clockalways returned0.0. This was verified by runningpllctl -R 16666which also read0.0and failed after that when setting the pll clock with invalid arguments.Making sure the register state is initialized before calling the
calculate_pll_clockmethod of the phy by callingread_registersfixed it.I'm not sure if this is the best place to initialize the register state. Maybe a call to
read_registersin the constructors of the phy implementations would be better?