This repository was archived by the owner on Aug 5, 2022. It is now read-only.
refkit-installer-image: image-installer fixes #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pohly
approved these changes
May 18, 2017
The $output*$gdisk_pnum wildcard listing is too greedy when the output is an eMMC device: it matches not only 'p' (in mmcblkXpY) but also 'boot' which is also found on eMMC devices. This results in a 'partition is not unique' error. To fix the install, limit the search to <device><partnum> and <device>p<partnum>. Signed-off-by: Mikko Ylinen <mikko.ylinen@linux.intel.com>
The target EFI partition needs the RMC db too which was not copied. Update the installer to take care of that too. Signed-off-by: Mikko Ylinen <mikko.ylinen@linux.intel.com>
The loop devices are not correctly removed when exiting due to a problem with kpartx -d failing to handle file names longer than 63. The workaround is to clean up using the loop device name with 'kpartx -d'. It also requires an explicit 'losetup -d' call. Signed-off-by: Mikko Ylinen <mikko.ylinen@linux.intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.