src: resolve Coverity hits #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andy51
approved these changes
Aug 7, 2025
ichepiga
approved these changes
Aug 7, 2025
| } | ||
| return _N_(_ittapi_global).state; | ||
| state = _N_(_ittapi_global).state; | ||
| if (PTHREAD_SYMBOLS) __itt_mutex_unlock(&_N_(_ittapi_global).mutex); |
Contributor
There was a problem hiding this comment.
Why init&lock are performed with macros and unlock with function?
Contributor
Author
There was a problem hiding this comment.
A macro is preferred for init and lock because it can inline platform-specific logic, atomic checks, and initialization steps directly into the calling code. This avoids function call overhead and ensures the mutex is initialized and locked efficiently.
The unlock __itt_mutex_unlock() is a simple function call of the pthread_mutex_unlock(), and it does not require the extra logic.
But I also don't like the inconsistency you pointed out, and I will take that into account in future code improvements, thanks for the comment!
lalithsharan-intel
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Coverity static analysis tool hits:
_N_(_ittapi_global).statein theget_collection_state()to ensure thread safety.bind_context_metadata_to_counter implemantation()from the dynamic library to prevent double-unlocking and unnecessary work.