Skip to content
This repository was archived by the owner on Oct 23, 2023. It is now read-only.

Conversation

@xiaowei0916
Copy link
Contributor

Signed-off-by: Li Xiaowei xiaowei.a.li@intel.com

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better if it's follow public->protected->private order.

@halleyzhao
Copy link
Contributor

thanks guangxin's feedback.

since web merge create

  1. redundant git log
  2. unclear parent-child relation when: two pull request is sent without conflict but basing on same master commit .

after review, please try below command instead:

in working git tree of team repo

git checkout -b xiaowei0916-master master
git pull https://github.com/xiaowei0916/libyami.git master
git push origin HEAD:master

Signed-off-by: Li Xiaowei <xiaowei.a.li@intel.com>
@halleyzhao
Copy link
Contributor

xiaowei has integrated it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants