[UR] CTS tests for command-buffer native append#17494
Merged
sommerlukas merged 1 commit intointel:syclfrom Mar 21, 2025
Merged
Conversation
EwanC
force-pushed
the
ur_cmd-buf_native-command_cts
branch
from
1278a00 to
0220354
Compare
EwanC
force-pushed
the
ur_cmd-buf_native-command_cts
branch
from
0220354 to
f49c62c
Compare
EwanC
force-pushed
the
ur_cmd-buf_native-command_cts
branch
from
f49c62c to
3469dba
Compare
EwanC
force-pushed
the
ur_cmd-buf_native-command_cts
branch
from
3469dba to
710da5d
Compare
EwanC
force-pushed
the
ur_cmd-buf_native-command_cts
branch
from
710da5d to
903d4d7
Compare
EwanC
commented
Mar 19, 2025
Bensuo
approved these changes
Mar 19, 2025
kbenzie
reviewed
Mar 19, 2025
EwanC
force-pushed
the
ur_cmd-buf_native-command_cts
branch
from
903d4d7 to
33b77d2
Compare
EwanC
force-pushed
the
ur_cmd-buf_native-command_cts
branch
from
33b77d2 to
64c23b9
Compare
kbenzie
approved these changes
Mar 20, 2025
Contributor
Author
|
@intel/llvm-gatekeepers This is good to merge, thanks |
Contributor
@EwanC There's still one CI job (Linux Intel Battlemage) running, let's wait for that to finish first. |
Contributor
Author
Apologies, I could have sworn when I refreshed my browser tab earlier the checks were all finished. They checks should be all finished and green now (I think!) |
Contributor
No worries, to me it looked a bit like a retry of the previously failed Battlemage job. I don't know if we have automatic retries configured or if some action triggered the re-run. |
EwanC
pushed a commit
to reble/llvm
that referenced
this pull request
Mar 21, 2025
All UR command-buffer CTS tests are marked as XFail on V2 [See CTS generic base class for command-buffer](https://github.com/intel/llvm/blob/sycl/unified-runtime/test/conformance/exp_command_buffer/fixtures.h#L48) This was omitted by accident from the new command-buffer CTS tests added in intel#17494 which don't derive from that base class. Fixed by adding in now.
uditagarwal97
pushed a commit
that referenced
this pull request
Mar 21, 2025
All UR command-buffer CTS tests are marked as XFail on V2 [See CTS generic base class for command-buffer](https://github.com/intel/llvm/blob/sycl/unified-runtime/test/conformance/exp_command_buffer/fixtures.h#L48) This was omitted by accident from the new command-buffer CTS tests added in #17494 which don't derive from that base class. Fixed by adding in now.
RossBrunton
pushed a commit
to oneapi-src/unified-runtime
that referenced
this pull request
Mar 24, 2025
All UR command-buffer CTS tests are marked as XFail on V2 [See CTS generic base class for command-buffer](https://github.com/intel/llvm/blob/sycl/unified-runtime/test/conformance/exp_command_buffer/fixtures.h#L48) This was omitted by accident from the new command-buffer CTS tests added in intel/llvm#17494 which don't derive from that base class. Fixed by adding in now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The merged PR #16871 introduced new UR entry-points
urCommandBufferAppendNativeCommandExpandurCommandBufferGetNativeHandleExp, however there was no UR CTS coverage forurCommandBufferAppendNativeCommandExpincluded, as verification was done via SYCL E2E testing.This PR adds UR CTS testing for
urCommandBufferAppendNativeCommandExpfor all of the L0, CUDA, HIP, and OpenCL adapters.Resolves #17448