[SYCL][UR] Implement sycl_ext_oneapi_device_wait #20377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the following changes to the behavior of asynchronous
exception handling:
1. The death of a queue should not consume asynchronous exceptions.
2. Calling wait_and_throw on an event after the associated queue has
died should still consume exceptions that were originally associated
with the queue. This should respect the async_handler priority to
the best of its ability.
3. Calling wait_and_throw or throw_asynchronous on a queue without an
async_handler should fall back to using the async_handler of the
associated context, then the default async_handler if none were
attached to the context.
Additionally, this lays the ground work for
intel#20266 by moving the tracking of
unconsumed asynchronous exception to the devices.
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
This commit removes a test case where the default handler would be used if the queue dies. This test case was unreliable as there was no way to ensure that the runtime was not keeping the queue alive for internal reasons. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
force-pushed
the
steffen/device_wait
branch
from
c3570ae to
5c29b43
Compare
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
steffenlarsen
force-pushed
the
steffen/device_wait
branch
from
5c29b43 to
93fb400
Compare
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
steffenlarsen
force-pushed
the
steffen/device_wait
branch
from
93fb400 to
ea69fb9
Compare
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
force-pushed
the
steffen/device_wait
branch
from
ea69fb9 to
1c2995d
Compare
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
steffenlarsen
force-pushed
the
steffen/device_wait
branch
from
1c2995d to
25c5cd9
Compare
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
This commit implements the UR functionality for device-wide synchronization and the SYCL APIs using it. The latter implements the sycl_ext_oneapi_device_wait extension. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
force-pushed
the
steffen/device_wait
branch
from
25c5cd9 to
bf37568
Compare
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Contributor
Author
|
@intel/llvm-reviewers-runtime & @intel/dpcpp-tools-reviewers - Linux drivers now support the device-wide synchronization, so this patch is ready for review! 🥳 |
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
steffenlarsen
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
approved these changes
Dec 17, 2025
Contributor
YuriPlyakhin
left a comment
YuriPlyakhin
left a comment
There was a problem hiding this comment.
LGTM for dpcpp-tools
Contributor
Author
|
@intel/llvm-reviewers-runtime - Friendly ping and happy new year! 🎆 |
uditagarwal97
approved these changes
Jan 6, 2026
Contributor
|
@intel/llvm-gatekeepers please consider merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the UR functionality for device-wide synchronization and the SYCL APIs using it. The latter implements the sycl_ext_oneapi_device_wait extension.