[SYCL] A fix for a redefinition in nan builtin helper on MSVC compiler #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@alexeyvoronov, could you clarify in the commit message why "Update ..." is required? |
alexeyvoronov-intel
force-pushed
the
private/avoronov/fix_type_traits
branch
from
df50584 to
c413c06
Compare
Before this patch the helper did explicitly map integer types to
suitable floating point type.
aka
template<> struct helper<cl_int> { using type = cl_int;}
But this does not work on Windows compiler x64 because there is
cl_long defined as an alias of long long. And this helper did generate
the redefinition error.
Fixed by change the mapping rules of the helper to mapping by size
comparing of integer and floating point types.
aka
template<T>
struct helper<T, enable_if_t<sizeof(T) == sizeof(cl_float), T>>
{ using type = cl_float; }
Signed-off-by: Alexey Voronov <alexey.voronov@intel.com>
alexeyvoronov-intel
force-pushed
the
private/avoronov/fix_type_traits
branch
from
c413c06 to
69fb305
Compare
alexeyvoronov-intel
changed the title
Contributor
Author
Added the description. |
Contributor
This is a bug in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SYCL] A fix for a redefinition in nan builtin helper on MSVC compiler
Before this patch the helper did explicitly map integer types to
suitable floating point type.
aka
template<> struct helper<cl_int> { using type = cl_int;}But this does not work on Windows compiler x64 because there is
cl_long defined as an alias of long long. And this helper did generate
the redefinition error.
Fixed by change the mapping rules of the helper to mapping by size
comparing of integer and floating point types.
aka
Signed-off-by: Alexey Voronov alexey.voronov@intel.com