Skip to content

Ort openvino npu 1.17 master#351

Closed
sfatimar wants to merge 59 commits intomasterfrom
ort-openvino-npu-1.17-master
Closed

Ort openvino npu 1.17 master#351
sfatimar wants to merge 59 commits intomasterfrom
ort-openvino-npu-1.17-master

Conversation

@sfatimar
Copy link

Description

Motivation and Context

sspintel and others added 30 commits March 12, 2024 23:14
Since there's a common GlobalContext, when we create two Sessions in the same user code,
the provider options of the first model gets overwritten with the second model's.

To overcome this, this PR creates an instance of GlobalContext for each instance of
OpenVINOExecutionProvider and uses it throughout wherever access to the GlobalContext's parameters are required.
@saurabhkale17 saurabhkale17 force-pushed the ort-openvino-npu-1.17-master branch from f7a643b to ea4001b Compare March 13, 2024 06:24
#elif OPENVINO_CONFIG_NPU_U8
#define BACKEND_OPENVINO "-OPENVINO_NPU_U8"
#elif OPENVINO_CONFIG_NPU
#define BACKEND_OPENVINO "-OPENVINO_NPU"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the latest changes preetha made on 1.17 for pybind in this branch ?

@sspintel sspintel force-pushed the ort-openvino-npu-1.17-master branch from b93eb63 to 56ce6fb Compare March 13, 2024 11:13
GetGlobalContext(),
subgraph_context_);
} catch (std::string const& msg) {
} catch (const OnnxRuntimeException& ex) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In ov interface.cc and basic_backend.cc we are throwing ORT_THROW(msg) on getting exception
should we not throw exception

@sfatimar
Copy link
Author

I am seeing this error
#11 4.765 /bin/sh: 1: cd: can't cd to /opt/intel/openvino_2023.0.0/install_dependencies

Even when we specify
ARG OPENVINO_VERSION=2024.0.0
ENV INTEL_OPENVINO_DIR /opt/intel/openvino_${OPENVINO_VERSION} ….
cd $INTEL_OPENVINO_DIR/install_dependencies

It seems to me that there the environment is not cleaned properly and it is picking up an old directory. Can you please check.

wget https://storage.openvinotoolkit.org/repositories/openvino/packages/2024.0/linux/l_openvino_toolkit_ubuntu20_2024.0.0.14509.34caeefd078_x86_64.tgz && \
tar xzf l_openvino_toolkit_ubuntu20_2024.0.0.14509.34caeefd078_x86_64.tgz && rm -rf l_openvino_toolkit_ubuntu20_2024.0.0.14509.34caeefd078_x86_64.tgz && \
mv l_openvino_toolkit_ubuntu20_2024.0.0.14509.34caeefd078_x86_64 openvino_2024.0.0 && \
cd $INTEL_OPENVINO_DIR/install_dependencies && ./install_openvino_dependencies.sh -y

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can use Debian packages instead of archives? It's more natural way for docker files, which are based on Ubuntu. NPU is part of Debian packages as well.

Note, current dockerfile is based on Ubuntu 20.04, which is not supported by NPU.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Microsoft PR is already Raised microsoft#19966 Thanks for your comments . We will track this is in the next PR. It should not be problem because docker is only for CPU. But yes we will change the dockerfile. Currently it does not seem possible because with Ubuntu base image we may need to do SDLE Process.

@sfatimar sfatimar closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants