Implements blob compatibility check for NPU#430
Merged
preetha-intel merged 5 commits intoovep-develop-lnl-1.2from Sep 4, 2024
Merged
Implements blob compatibility check for NPU#430preetha-intel merged 5 commits intoovep-develop-lnl-1.2from
preetha-intel merged 5 commits intoovep-develop-lnl-1.2from
Conversation
preetha-intel
requested review from
ankitm3k,
jatinwadhwa921,
sfatimar and
vthaniel
sfatimar
reviewed
Aug 28, 2024
onnxruntime/core/providers/openvino/openvino_execution_provider.cc
Outdated
Show resolved
Hide resolved
|
Please check other EP Codes to see how they handle failure in Compile call |
* OVEP catches the NPU driver exception and return failure status * NPU to CPU fallback is disabled when inferencing with blob
vthaniel
force-pushed
the
sriram/blob_compatibility_check
branch
from
31b4e5e to
4c4a5b2
Compare
srirammaswamy-intel
force-pushed
the
sriram/blob_compatibility_check
branch
2 times, most recently
from
539c7d1 to
c80fd27
Compare
vthaniel
force-pushed
the
sriram/blob_compatibility_check
branch
from
c80fd27 to
5429e55
Compare
* Changes failure status code to exception (std::runtime_error) * Capture all NPU related errors * Throw minimal error message with error type and error code for Release builds
vthaniel
force-pushed
the
sriram/blob_compatibility_check
branch
from
5429e55 to
e4ff4ba
Compare
|
LGTM |
preetha-intel
commented
Sep 2, 2024
preetha-intel
commented
Sep 2, 2024
preetha-intel
commented
Sep 3, 2024
preetha-intel
commented
Sep 3, 2024
|
@srirammaswamy-intel can you please close on the review comments by Preetha |
|
@preetha-intel can you please close on this. |
vthaniel
force-pushed
the
sriram/blob_compatibility_check
branch
from
dc71179 to
f5ca289
Compare
preetha-intel
commented
Sep 4, 2024
saurabhkale17
force-pushed
the
ovep-develop-lnl-1.2
branch
from
1ecb48b to
0545117
Compare
vthaniel
force-pushed
the
sriram/blob_compatibility_check
branch
from
f5ca289 to
4203dcb
Compare
Author
|
LGTM |
sfatimar
pushed a commit
that referenced
this pull request
Sep 6, 2024
* Implements blob compatibility check for NPU * OVEP catches the NPU driver exception and return failure status * NPU to CPU fallback is disabled when inferencing with blob * Update NPU device exception handling approach * Changes failure status code to exception (std::runtime_error) * Capture all NPU related errors * Throw minimal error message with error type and error code for Release builds * Fix lint issues * Address review comments * Address review comments --------- Co-authored-by: Srirammaswamy <srirammaswamy.s@intel.com>
sfatimar
pushed a commit
that referenced
this pull request
Sep 6, 2024
* Implements blob compatibility check for NPU * OVEP catches the NPU driver exception and return failure status * NPU to CPU fallback is disabled when inferencing with blob * Update NPU device exception handling approach * Changes failure status code to exception (std::runtime_error) * Capture all NPU related errors * Throw minimal error message with error type and error code for Release builds * Fix lint issues * Address review comments * Address review comments --------- Co-authored-by: Srirammaswamy <srirammaswamy.s@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context