Disable driver caching for NPU when epctx enabled for ov version greater then 2024.3#443
Merged
sfatimar merged 1 commit intoovep-develop-lnl-1.2from Sep 6, 2024
Merged
Conversation
jatinwadhwa921
requested review from
ankitm3k,
preetha-intel,
saurabhkale17,
sfatimar and
vthaniel
sfatimar
reviewed
Sep 6, 2024
| device_property = std::make_pair("NPU_COMPILER_TYPE", env_npu_compiler_type); | ||
| } | ||
| device_config.emplace(ov::device::properties("NPU", device_property)); | ||
| if (global_context_.export_ep_ctx_blob) { |
There was a problem hiding this comment.
should not the if comment be also under #Ifdef
vthaniel
reviewed
Sep 6, 2024
| } | ||
| device_config.emplace(ov::device::properties("NPU", device_property)); | ||
| if (global_context_.export_ep_ctx_blob) { | ||
| #if (OPENVINO_VERSION_MAJOR >= 2024) && (OPENVINO_VERSION_MINOR > 3) |
There was a problem hiding this comment.
We might need to change this condition for later releases of OV like 2025.1
saurabhkale17
force-pushed
the
jatin/ov_2024_4_cache_fix
branch
from
9e5ab07 to
6561626
Compare
sfatimar
force-pushed
the
ovep-develop-lnl-1.2
branch
from
236df14 to
b0a8bee
Compare
sfatimar
force-pushed
the
jatin/ov_2024_4_cache_fix
branch
from
6561626 to
df7febe
Compare
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disable driver caching for NPU when epctx enabled for ov version greater then 2024.3