[EISW-140760] Device memory refactor fix#466
Merged
saurabhkale17 merged 1 commit intoovep-develop-lnl-1.2from Oct 3, 2024
Merged
[EISW-140760] Device memory refactor fix#466saurabhkale17 merged 1 commit intoovep-develop-lnl-1.2from
saurabhkale17 merged 1 commit intoovep-develop-lnl-1.2from
Conversation
|
LGTM. Model passes functionality with default CPU allocator. FYI: More details in the ticket: https://jira.devtools.intel.com/browse/EISW-140760 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix ORT crash caused when running with OVEP without device memory. The crash was root caused to be due to
outputs_array only set when device memory is used. Fixed by populatingoutputs_array in both cases, with and without device memory.Motivation and Context
Fix P1 issue from https://jira.devtools.intel.com/browse/EISW-140760