Skip to content
This repository was archived by the owner on Dec 17, 2022. It is now read-only.

Conversation

@Meadosc
Copy link
Contributor

@Meadosc Meadosc commented Nov 6, 2019

Add ML code for pix2pix

@Meadosc Meadosc requested review from DnPlas and unrahul November 6, 2019 18:58
@Meadosc Meadosc self-assigned this Nov 6, 2019
@unrahul unrahul changed the title ML code [pix2pix]: ML code Nov 6, 2019
except ModuleNotFoundError:
from helper import get_directory

url = "https://people.eecs.berkeley.edu/~tinghuiz/projects/pix2pix/datasets/facades.tar.gz"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cord add to readme this attribution for facades dataset that we used: https://github.com/phillipi/pix2pix/blob/master/datasets/bibtex/facades.tex

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Citation is added

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add one more for the dataset: http://cmp.felk.cvut.cz/~tylecr1/facade/

Copy link
Contributor

@unrahul unrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the readme with facades dataset attribution as in: https://github.com/phillipi/pix2pix/blob/master/datasets/bibtex/facades.tex
And this looks good to be merged.

journal={CVPR},
year={2017}
}
``` No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add one more for the dataset from here : http://cmp.felk.cvut.cz/~tylecr1/facade/

@unrahul unrahul self-requested a review November 6, 2019 19:25
Copy link
Contributor

@unrahul unrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Meadosc


#### Inference
```bash
python infer.py
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention that if running this you should uncomment the last line of infer.py? Also, we need an img as argument

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good point. @cord ^^

Copy link
Contributor

@unrahul unrahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 lgtm, thanks @Meadosc

@unrahul unrahul merged commit 1848b3c into intel:master Nov 6, 2019
@Meadosc Meadosc deleted the publish branch November 12, 2019 19:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants