-
Notifications
You must be signed in to change notification settings - Fork 17
Conversation
| except ModuleNotFoundError: | ||
| from helper import get_directory | ||
|
|
||
| url = "https://people.eecs.berkeley.edu/~tinghuiz/projects/pix2pix/datasets/facades.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cord add to readme this attribution for facades dataset that we used: https://github.com/phillipi/pix2pix/blob/master/datasets/bibtex/facades.tex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Citation is added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add one more for the dataset: http://cmp.felk.cvut.cz/~tylecr1/facade/
unrahul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update the readme with facades dataset attribution as in: https://github.com/phillipi/pix2pix/blob/master/datasets/bibtex/facades.tex
And this looks good to be merged.
| journal={CVPR}, | ||
| year={2017} | ||
| } | ||
| ``` No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add one more for the dataset from here : http://cmp.felk.cvut.cz/~tylecr1/facade/
unrahul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Meadosc
pix2pix/README.md
Outdated
|
|
||
| #### Inference | ||
| ```bash | ||
| python infer.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we mention that if running this you should uncomment the last line of infer.py? Also, we need an img as argument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good point. @cord ^^
unrahul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 lgtm, thanks @Meadosc
Add ML code for pix2pix