Makefile: Use file name instead of file descriptor for .config target#210
Merged
thiagomacieira merged 1 commit intointel:mainfrom Oct 4, 2021
Merged
Makefile: Use file name instead of file descriptor for .config target#210thiagomacieira merged 1 commit intointel:mainfrom
thiagomacieira merged 1 commit intointel:mainfrom
Conversation
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project makefile uses fd 9 to redirect output, when generating the contents of the
.configfile. Previously, it used fd 10, but was changed due to compatibility concerns (c88913e).The build fails in environments where this file descriptor can't be used. I've encountered this error trying to build
tinycboras part of a dependency, from a Cargo crate build script which invokesmake(see logs):Proposing a fix, changing the
OUTvariable to take a path to append to, instead of a redirection.I've tested the change by running
make, and verifying the contents of.configare the same as before my change.