cborpretty: fix assertion failure if recursion limit was hit#230
Merged
thiagomacieira merged 1 commit intomainfrom Feb 13, 2023
unknown repository
Merged
cborpretty: fix assertion failure if recursion limit was hit#230thiagomacieira merged 1 commit intomainfrom unknown repository
thiagomacieira merged 1 commit intomainfrom
unknown repository
Conversation
ghost
changed the title
ghost
deleted the
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
cbordumpon the enclosed input fails with an assertion error :The problem is the following : there is an implicit assumption when quitting
container_to_prettythat the iterator is advanced to its end. This assumption is broken whenever we reach the recursion limit.The failing input was found by @niooss-ledger.
max-recurse-limit-fail-input.txt