Skip to content

Use _Float16 for half conversions if available#231

Merged
thiagomacieira merged 1 commit intointel:mainfrom
kalcutter:float16-half-conversions
Feb 24, 2023
Merged

Use _Float16 for half conversions if available#231
thiagomacieira merged 1 commit intointel:mainfrom
kalcutter:float16-half-conversions

Conversation

@kalcutter
Copy link
Contributor

Implement support for half-precision floating-point conversions using _Float16 introduced in C11 extension ISO/IEC TS 18661-3.

Recent ARM compilers support _Float16.

Copy link
Member

@thiagomacieira thiagomacieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just the minor suggestion.

Recent ARM compilers support _Float16.

The reason for that is that x86 finally got it too (GCC 12 added support) and that C++ is getting this in P1467

@kalcutter
Copy link
Contributor Author

kalcutter commented Feb 23, 2023

The reason for that is that x86 finally got it too (GCC 12 added support) and that C++ is getting this in P1467

I didn't mean that "recent". 😄 Even 3-year old clang supports this on ARM: https://godbolt.org/z/o3T5oWv57

@kalcutter
Copy link
Contributor Author

The reason for that is that x86 finally got it too (GCC 12 added support) and that C++ is getting this in P1467

Nice... clang 15 also has x86 support now finally.

@thiagomacieira
Copy link
Member

The reason for that is that x86 finally got it too (GCC 12 added support) and that C++ is getting this in P1467

Nice... clang 15 also has x86 support now finally.

I didn't think _Float16 worked up until recently; __fp16 did though.

Implement support for half-precision floating-point conversions using
`_Float16` introduced in C11 extension ISO/IEC TS 18661-3.
@thiagomacieira thiagomacieira merged commit 3cba6b1 into intel:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants