set public header include dir for fixing header prefix#298
Open
jhlee525 wants to merge 1 commit intointel:mainfrom
Open
set public header include dir for fixing header prefix#298jhlee525 wants to merge 1 commit intointel:mainfrom
jhlee525 wants to merge 1 commit intointel:mainfrom
Conversation
thiagomacieira
requested changes
Apr 30, 2025
Member
thiagomacieira
left a comment
thiagomacieira
left a comment
There was a problem hiding this comment.
I don't like not having the header file right next to the sources. Can you keep the cbor.h header exactly where it is, but instead add include/tinycbor/cbor.h
#include "../../src/cbor.h"?
Why does everything else need changing?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the previous PR(#297), the install directory for cbor.h was changed to tinycbor/cbor.h.
it causes problem when using FetchContent, since it import headers directly from the source code. (It actually placed in
src/tinycbor.h).I created a dedicated public header directory
includeby convention, and placedinclude/tinycbor/cbor.h.Since all source files reference just
cbor.h, I have to updated all include paths accordingly.I checked
testsandtoolsare able to compile, but not tested for all option sets.Apologies for the big changes, If you prefer not to adopt this change, feel free to revert #297.