Problem
The JoinRequest handler in crates/client/src/listeners.rs:309-339 validates join links and increments the used counter, but the invite generation closure always returns None::<String> with a comment "For now, just return None — full invite generation needs refactoring."
This means:
- Valid join requests are silently dropped after consuming a use count
- The link's
used counter is incremented even though no invite is sent
- Join-via-link is completely non-functional
Suggested fix
Implement the invite generation in the JoinRequest handler, or stop incrementing the used counter until invite generation is implemented.
Location
crates/client/src/listeners.rs:309-339
Found during audit of #26.
Problem
The
JoinRequesthandler incrates/client/src/listeners.rs:309-339validates join links and increments theusedcounter, but the invite generation closure always returnsNone::<String>with a comment "For now, just return None — full invite generation needs refactoring."This means:
usedcounter is incremented even though no invite is sentSuggested fix
Implement the invite generation in the JoinRequest handler, or stop incrementing the
usedcounter until invite generation is implemented.Location
crates/client/src/listeners.rs:309-339Found during audit of #26.