File: crates/identity/Cargo.toml:23 + Spec: CLAUDE.md "Dual-Target Support"
Severity: quality — minor, dev-only
Obvious? no
crates/identity/Cargo.toml lists tokio = { workspace = true } under [dev-dependencies]. Lib-crate guidance in CLAUDE.md says "no tokio in lib crates" but is silent on tests.
No production code path uses tokio (rg "tokio::" crates/identity/src is empty). Either harmless or worth a comment explaining why tests need a runtime; flagging because it's the only lib crate below client/network to pull tokio at all.
Fix: drop the dev-dep if unused, or add # tests use tokio::test for async signing benchmarks comment so future readers don't wonder.
Filed by /general-audit @ b901575 (2026-05-02). master: #513.
File:
crates/identity/Cargo.toml:23+ Spec: CLAUDE.md "Dual-Target Support"Severity: quality — minor, dev-only
Obvious? no
crates/identity/Cargo.tomlliststokio = { workspace = true }under[dev-dependencies]. Lib-crate guidance in CLAUDE.md says "no tokio in lib crates" but is silent on tests.No production code path uses tokio (
rg "tokio::" crates/identity/srcis empty). Either harmless or worth a comment explaining why tests need a runtime; flagging because it's the only lib crate belowclient/networkto pull tokio at all.Fix: drop the dev-dep if unused, or add
# tests use tokio::test for async signing benchmarkscomment so future readers don't wonder.Filed by
/general-audit@b901575(2026-05-02). master: #513.