Skip to content

audit F18 [quality]: ICE candidate handle_ice_candidate result swallowed #585

@intendednull

Description

@intendednull

File: crates/web/src/event_processing.rs:128
Severity: quality
Obvious? yes

let _ = vm.borrow().handle_ice_candidate(&from, json); discards a Result from a critical voice-call signaling path. Module-doc on handlers.rs:10 explicitly calls out let _ = ... discards as an antipattern that needs typed handling.

Fix: at minimum log via tracing::warn! so failed ICE exchanges aren't silent.


Filed by /general-audit @ 6404719 (2026-05-03). master: #567.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions