Skip to content

audit F20 [quality]: WebRTC error closures log JsValue with Debug, not Display #587

@intendednull

Description

@intendednull

File: crates/web/src/components/file_share.rs:69
Severity: quality
Obvious? no

tracing::error!("FileReader result error: {e:?}"); — JsValue Debug rendering is sometimes opaque (e.g. JsValue(Object)). Use web_sys/gloo helpers to extract .message() from a DOMException or fall back to JsValueSerdeExt::into_serde for richer logs.

Fix: improves on-call diagnosis when users report "share failed".


Filed by /general-audit @ 6404719 (2026-05-03). master: #567.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions