Skip to content

audit F24 [quality]: longPressAvatar uses bare waitForTimeout(500) for press-hold threshold #591

@intendednull

Description

@intendednull

File: e2e/helpers/touch.ts:150
Severity: quality
Obvious? yes

longPressAvatar does mouse.down() / waitForTimeout(500) / mouse.up() — the timer is the only signal that crosses the long-press threshold. If the threshold ever shifts above 500ms (or runner under load delays event delivery), this returns false negatives.

Fix: either (a) parameterise durationMs with a buffer over the actual LONG_PRESS_MS constant, or (b) install page.clock like longPressWithClock already does and runFor(LONG_PRESS_MS + ε) deterministically.


Filed by /general-audit @ 6404719 (2026-05-03). master: #567.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions