Add CI workflow and apply rustfmt formatting#10
Merged
Conversation
Add a CI workflow (fmt, clippy, test, WASM check) that runs on PRs and pushes to main. Update the deploy workflow to depend on CI passing before deploying. Fix formatting issues across the workspace. https://claude.ai/code/session_019cmP1WsNbaf7AYLH7Naxgm
Box large enum variants (WorkerResponse in WorkerWireMessage::Response, ServerState in WorkerResponse::Snapshot) and derive Default for AllocationStrategy to satisfy clippy -D warnings. https://claude.ai/code/session_019cmP1WsNbaf7AYLH7Naxgm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a comprehensive CI/CD pipeline and applies consistent code formatting across the codebase using rustfmt.
Key Changes
CI/CD Pipeline
.github/workflows/ci.yml): Automated checks on push to main and pull requestscargo fmtclippy(all warnings treated as errors)cargo testwasm32-unknown-unknowntarget.github/workflows/deploy.yml): Now depends on CI passing before deploymentCode Formatting
Applied rustfmt formatting across multiple files to improve consistency:
Type Safety Improvements
WorkerResponseinBoxforResponse.payloadto reduce enum sizeServerStateinBoxforSnapshot.stateto reduce enum sizeAllocationStrategy::Defaultimpl to derive macroMinor Refactoring
Implementation Details
The CI workflow uses
dtolnay/rust-toolchain@stablefor consistent Rust versions and implements separate caching strategies per job to optimize build times. The WASM check excludes relay, worker, replay, and storage crates that don't target WASM.https://claude.ai/code/session_019cmP1WsNbaf7AYLH7Naxgm