chore: drop stale dead_code allows + dead helper#398
Merged
Conversation
Two web/state.rs fields (settings_tab, voice_participants_map) and one client/storage.rs helper (save_download) carried #[allow(dead_code)] from in-flight PRs that have since landed or closed. Fields now read across app.rs, event_processing.rs, call_page.rs, channel_sidebar.rs. save_download has zero callers anywhere in the tree. Closes #196
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Stale
#[allow(dead_code)]from old in-flight work. Fields now read. Helper unused.Changes
web/state.rs: drop allow onsettings_tab(read in app.rs, written 4 places).web/state.rs: drop allow onvoice_participants_map(read in event_processing.rs, app.rs, call_page.rs, channel_sidebar.rs).client/storage.rs: deletesave_downloadfn (zero callers anywhere).Verify
cargo fmt --check,cargo clippy --workspace --all-targets -- -D warnings,cargo test --workspace,cargo check --target wasm32-unknown-unknownall clean.Closes #196
Generated by Claude Code