ci(audit): ignore unmaintained transitive advisories (#316/#317/#318)#402
Merged
Merged
Conversation
This was referenced Apr 27, 2026
Closed
intendednull
pushed a commit
that referenced
this pull request
Apr 28, 2026
…ional three lessons from batch 2026-04-28-002530: 1. coordinator must `git fetch + reset` master batch branch before each implementer dispatch — stale local state contaminates the next worktree (#451 implementer found half-applied prior work in fresh worktree). 2. when implementer's pre-flight detects upstream fix already landed (#316/#317/#318 vs PR #402), close issues + caveman-comment, do NOT include in master PR `Fixes` list — record under `## Already-Fixed` instead. 3. github webhook subscriptions for sub-PRs are informational only — implementer owns its merge gate, coordinator must not duplicate that work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Three RUSTSEC unmaintained advisories trip CI audit gate. All transitive, no path from our code:
RUSTSEC-2024-0436—paste 1.0.15archived Oct 2024 ([DEP-08] Unmaintainedpaste 1.0.15(RUSTSEC-2024-0436) — not in CI ignore list #316)RUSTSEC-2024-0370—proc-macro-error 0.4.12unmaintained, drags syn 1.x ([DEP-09] Unmaintainedproc-macro-error 0.4.12(RUSTSEC-2024-0370) — not in CI ignore list #317)RUSTSEC-2023-0089—atomic-polyfill 1.0.3replaced by portable-atomic ([DEP-10] Unmaintainedatomic-polyfill 1.0.3(RUSTSEC-2023-0089) — not in CI ignore list #318)Upstream chains:
No trivial single-dep bump fixes any of these — iroh + leptos ecosystems both pin upstreams that haven't migrated. Bumping iroh/leptos = deep risk, separate work.
Fix
Add
--ignore RUSTSEC-XXXX-XXXXto existingcargo auditstep in.github/workflows/ci.yml. Matches existing style (inline#comment with tracking issue ref). Issues #316/#317/#318 stay open as tracking issues — not closed by this PR — until upstream fixes land or we bump iroh/leptos.Verify
Local before:
Local after (same flags as CI):
Tradeoff: ignoring vs upgrading. Upgrading rejected — iroh/leptos pin transitives, blast radius too large for this scope. Tracking issues capture follow-up.
Refs #316
Refs #317
Refs #318
Generated by Claude Code