fix(relay): log shutdown errors instead of swallowing#407
Merged
Conversation
`.shutdown().await.ok()` hid I/O errors. Replace with `if let Err(e)` + `tracing::warn!`. Non-fatal but observable. Closes #159
This was referenced Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
relay_server.shutdown().await.ok()swallowed errors. I/O fail, already-closed socket, anything — invisible. No log, no signal. Bad for observability.Fix
Replace
.ok()withif let Err(e)+tracing::warn!(%e, ...). Shutdown still non-fatal — relay process exits regardless — but failure now surfaces in logs. Matches existingtracing::error!(%e, ...)style nearby (lines 227-228).Swept relay crate for
.shutdown().await.ok()and.ok();— only one site found. No other instances in scope.Verify
cargo fmt --check -p willow-relaycleancargo clippy -p willow-relay --all-targets -- -D warningscleancargo test -p willow-relay17 tests passCloses #159
Generated by Claude Code