Skip to content

chore: prune #[allow(dead_code)] cluster (#327) #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
intendednull merged 1 commit into from
Apr 28, 2026
Merged

chore: prune #[allow(dead_code)] cluster (#327) #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion crates/actor/src/fsm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,10 @@ mod tests {
struct StrictDoor;

#[derive(Debug, Clone, PartialEq)]
#[allow(dead_code)]
#[allow(
dead_code,
reason = "Open variant exists for completeness; tests start in Closed and assert StrictDoor rejects further transitions."
)]
enum DoorState {
Open,
Closed,
Expand Down
8 changes: 0 additions & 8 deletions crates/web/src/app.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,6 @@ fn detect_platform() -> &'static str {
}
}

#[allow(dead_code)]
pub fn toggle_theme() {
js_sys::eval(
r#"var h=document.documentElement;var c=h.getAttribute('data-theme')||'dark';var n=c==='dark'?'light':'dark';h.setAttribute('data-theme',n);localStorage.setItem('willow-theme',n);"#,
)
.ok();
}

/// How many milliseconds to wait before clearing the loading state automatically.
const LOADING_TIMEOUT_MS: u32 = 5_000;

Expand Down
1 change: 0 additions & 1 deletion crates/web/src/components/mobile_shell.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ impl MobileTab {
/// Full-screen pushes that can be stacked over a primary tab. Each
/// push hides the tab bar and renders translated in from the right.
#[derive(Clone, PartialEq, Eq, Debug)]
#[allow(dead_code)]
pub enum MobilePush {
/// Channel chat view (name = channel id).
Channel(String),
Expand Down
1 change: 0 additions & 1 deletion crates/web/src/palette_recents.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ pub fn push(entry: Recent) {
}

/// Clear all recents.
#[allow(dead_code)]
pub fn clear() {
if let Some(s) = storage() {
let _ = s.remove_item(KEY);
Expand Down
2 changes: 0 additions & 2 deletions crates/web/src/state.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,9 +358,7 @@ pub struct ChatWriteSignals {
pub set_channels: WriteSignal<Vec<String>>,
pub set_replying_to: WriteSignal<Option<DisplayMessage>>,
pub set_editing: WriteSignal<Option<DisplayMessage>>,
#[allow(dead_code)]
pub set_pinned_messages: WriteSignal<Vec<DisplayMessage>>,
#[allow(dead_code)]
pub set_pin_labels: WriteSignal<HashMap<String, String>>,
pub set_channel_views: WriteSignal<HashMap<String, ChannelViewState>>,
}
Expand Down
4 changes: 0 additions & 4 deletions crates/web/tests/browser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ where
/// [`mount_test_with_shell`] to pin the choice via a `data-shell`
/// attribute on `<html>`.
#[derive(Clone, Copy, Debug, PartialEq, Eq)]
#[allow(dead_code)]
pub enum TestShell {
Desktop,
Mobile,
Expand All @@ -54,7 +53,6 @@ pub enum TestShell {
/// `.shell-desktop` / `.shell-mobile` visibility on that attribute
/// when present (falls back to the viewport media query when the
/// attribute is absent).
#[allow(dead_code)]
pub fn mount_test_with_shell<F, V>(shell: TestShell, view: F) -> web_sys::HtmlElement
where
F: FnOnce() -> V + 'static,
Expand All @@ -80,7 +78,6 @@ where
/// does not pull in the app's CSS via `index.html`; without this, every
/// element keeps its UA-default `display` and the shell override cannot
/// be observed.
#[allow(dead_code)]
fn ensure_components_css_loaded(doc: &web_sys::Document) {
const STYLE_ID: &str = "willow-test-components-css";
if doc.get_element_by_id(STYLE_ID).is_some() {
Expand Down Expand Up @@ -5771,7 +5768,6 @@ mod notifications {
/// `mobile_actions`). Each group used to carry its own copies of
/// `click_selector` / `fill_selector` / etc.; they are hoisted here so
/// new modules can reuse them without duplication.
#[allow(dead_code)]
mod test_support {
use super::*;
use willow_web::app::App;
Expand Down