auto-fix batch claude/friendly-maxwell-cVhhm (2026-04-30)#501
Merged
Conversation
… wasm clippy CI gate caveman go: get_month already u32 on wasm32. cast bad. clippy yell. fix yell. three sites swept in crates/web/src/components/message_row/day_separator.rs: - ts_m: drop `as u32` - now_m: drop `as u32` - y_m: drop `as u32` comment block above also tweaked to reflect that cast is no longer the NaN-collapse vector for `get_month` / `get_date` (it's the implicit u32 return that does the collapsing now); behaviour identical, doc just true. CI guard wired per issue Option 1 (no extra job, just a step in the existing wasm job). add `components: clippy` to the toolchain action + new step `cargo clippy --target wasm32-unknown-unknown -p willow-web --all-targets -- -D warnings` after the existing wasm cargo check. won't hit the wasm-streams duplicate-symbol blocker that reverted PR #498's CI guard: clippy is check-style, never links the wasm binary, so the duplicate-symbol link error can't fire here. verified locally — `cargo clippy --target wasm32-unknown-unknown -p willow-web --all-targets -- -D warnings` finishes clean, zero warnings. Refs #497
Run on `claude/friendly-maxwell-cVhhm` showed 6 of 7 picked issues were already-fixed-upstream (#465 by skill rewrite eliminating sub-PRs, #426 #438 #477 #493 by 8d91a11 folding lessons into general-audit, #429 by 1a9503f LRU+TTL on ProfileState/typing_peers). Dispatching implementers for no-op close-with-comment work wastes cycles. Promote already-fixed sweep to coordinator-direct first pass, BEFORE any implementer dispatch. Closing GH issues = metadata work, not code work, allowed under "coordinator never codes." Implementers only dispatch for unresolved issues. Renumber subsequent Core Loop steps (7-10).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
as u32casts (wasm32-only) #497 — drop 3 redundantas u32casts onjs_sys::Date::get_month()incrates/web/src/components/message_row/day_separator.rs; addcargo clippy --target wasm32-unknown-unknown -p willow-web --all-targets -- -D warningsstep to existingwasmjob in.github/workflows/ci.yml(Option 1 per issue, no extra job overhead). wasm-streams blocker not hit (clippy doesn't link). Commitc9f1ba6.Already-Fixed
resolved upstream before this run; coordinator-direct close pass (no implementer dispatch):
resolving-issuesskill rewrite eliminate sub-PR pattern. master PR opens againstmaindirect, fire main-gated CI normal. nopull_request.branchesglob change need..claude/skills/general-audit/SKILL.mdvia8d91a11.8d91a11).8d91a11).8d91a11).ProfileState.names+NetworkMeta.typing_peersship in1a9503f. verified by general-audit @0de7631(general-audit: main @ 0de7631 (2026-04-29) #492).Parked
none. all picked issues either shipped or already-fixed.
Skill Evolution
da21fed docs(skill): add coordinator-direct already-fixed sweep before dispatch— promote already-fixed sweep to first pass in Core Loop. coordinator close stale audit / lessons issues directly viamcp__github__add_issue_comment+mcp__github__issue_write, no implementer dispatch. closing GH issues = metadata work, not code, allowed under "coordinator never codes". implementers only dispatch for unresolved issues. saves dispatch overhead on no-op work — this run, 6/7 picks would have been wasted dispatches.Lessons Learned
mcp__github__list_issuestoken-cap. 50 open issues exceed 192k char tool-result cap. saved-to-file fallback + jq work but slow. for >25-issue label, prefermcp__github__search_issuesw/ narrower query (already noted in lesson Add deep-review skill for iterative code review #5 of general-audit lessons: 2026-04-29 #493 / general-audit skill — applies here too).clippy::too_many_argumentsallows — extract Props structs #195 (refactor 7 components, design discussion), Local dev relay URL auto-detection is fragile #102 (relay URL, design decisions), Search index: plumb active letter_id into IndexableMessage #441 (search index app-state shape, discussion).wasm32-unknown-unknowndoes NOT link, so the pre-existingwasm-streamsduplicate-symbol blocker (which killswasm-pack test+trunk build) doesn't affect this CI step. Confirmed locally — zero warnings, exit 0. CI gate was previously reverted (c5452a4) for a different guard that DID link; this one is safe.Test plan
master-PR CI runs the full gate:
cargo fmt,cargo clippy(native),cargo test,cargo check --target wasm32-unknown-unknown,wasm-pack test --headless --firefox, plus the newwasm-clippystep onwillow-web. Local merge gate verified green by implementer (c9f1ba6report):cargo fmt --all -- --check— cleancargo clippy --target wasm32-unknown-unknown -p willow-web --all-targets -- -D warnings— clean, zero warningscargo clippy --workspace --all-targets -- -D warnings(native) — cleancargo check --target wasm32-unknown-unknown -p willow-web— cleancargo test -p willow-web --lib— 77 passed, 0 failedGenerated by Claude Code