general-audit: fold lessons #552#553
Merged
Merged
Conversation
apply 6 lessons from 2026-05-02 audit run: - pass 1 sibling-of-closed: commit-prefix filter when N merged PRs > 5 - pass 3 cargo-audit: document first-run advisory-db prefetch (no -n) - synthesis dedup: forbid bare-keyword search_issues queries (78k cap) - synthesis verification: drop partially-verified findings whose body claim contradicts spot-check - file the issues: budget for batched MCP calls (≈ 2N+2) - agent prompts: require ±10 line read around any cited line before claiming "missing"/"absent" closes #552
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
caveman PR. folds 6 lessons from 2026-05-02 audit run into
.claude/skills/general-audit/SKILL.md.Closes #552. Master audit issue: #513.
Edits applied
docs:/chore:/skill-only commits, keepsfix:/feat:/perf:/refactor:. Auto-fix-batch PRs especially benefit.cargo audit -nfails on fresh runners; drop-nfor first run, keep for cached subsequent runs.search_issuesqueries (e.g."general-audit",label:auditalone). They overflow the 78k-char tool-result cap. Always pin a file path, symbol, or RUSTSEC ID.partially-verifiedfindings whose body claim contradicts spot-check, not justFAILED. Caught F28 (lock-ok marker present at line 23 contradicting "missing at line 31" claim) + F52 (aria-live present in chat.rs:387 contradicting "no aria-live for chat" claim) this run.Edits skipped
(none)
Auto-generated by
/general-audit. Human review required before merge.Generated by Claude Code