Merged
Conversation
GavinJoyce
force-pushed
the
gj/href-to
branch
2 times, most recently
from
720729d to
c9c95c1
Compare
addon/helpers/href-to.js
Outdated
Member
Author
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
Actually, I may do this later. I'll try integrating into embercom first
|
👏 |
There was a problem hiding this comment.
Probably a case of psychotic over-optimisation but you could avoid this conversation to jQuery and use:
https://developer.mozilla.org/en/docs/Web/API/Element/matches
https://developer.mozilla.org/en-US/docs/Web/API/Element/getAttribute
This code will be running on every click so might be worth it. (probably ok for a later enhancement)
Member
Author
There was a problem hiding this comment.
Thanks, I'll capture this in an issue and come back to it soon
Closed
addon/helpers/href-to.js
Outdated
There was a problem hiding this comment.
you could cache the router lookup inside the closure
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @paddyobrien