Support Glimmer's LinkTo components as well#155
Closed
himynameisjonas wants to merge 1 commit intointercom:masterfrom
Closed
Support Glimmer's LinkTo components as well#155himynameisjonas wants to merge 1 commit intointercom:masterfrom
himynameisjonas wants to merge 1 commit intointercom:masterfrom
Conversation
Author
|
I saw #152 just as a had submitted this PR. That PR has a more robust solution to the same problem so I'm closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had some weird bugs in our app until we found this issue where
isLinkComponentis false even if it is a real LinkTo component. Seems like the inheritance chain for LinkTo components has changed and it doesn't work to compare with the class fromlegacy-built-in-components.My fix was the quickest solution I could think of, there is probably a better/nicer solution you could implement to fix the test I added.