Replace most jQuery methods#35
Closed
oskarrough wants to merge 1 commit intointercom:masterfrom
oskarrough:less-jquery
Closed
Replace most jQuery methods#35oskarrough wants to merge 1 commit intointercom:masterfrom oskarrough:less-jquery
oskarrough wants to merge 1 commit intointercom:masterfrom
oskarrough:less-jquery
Conversation
| let $body = Em.$(document.body); | ||
| const router = applicationInstance.container.lookup('router:main'); | ||
| const rootURL = _getNormalisedRootUrl(router); | ||
| const $body = Em.$(document.body); |
Member
There was a problem hiding this comment.
I think these should be lets: http://madhatted.com/2016/1/25/let-it-be
Member
|
@oskarrough thanks for working on this. I'm not sure if there is much value in removing jQuery however, especially as this addon is likely to be added to the ember framework at some point as |
Author
|
Sure, I agree — feel free to close the pull request if you'd rather skip it. Otherwise I'll just change the const/let. Let me know. |
Member
|
Thanks, I'll close the issue and PR. Thanks for contributing 🍻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A work in progress to replace jQuery. See #2
I had to polyfill classList but perhaps this is where jQuery should be kept? Same with the click events.