Skip to content
This repository was archived by the owner on Apr 24, 2023. It is now read-only.

Remove dependence on Enumerable utils#1

Merged
paddyobrien merged 1 commit intomasterfrom
remove-enumerable-utils
Oct 8, 2015
Merged

Remove dependence on Enumerable utils#1
paddyobrien merged 1 commit intomasterfrom
remove-enumerable-utils

Conversation

@paddyobrien
Copy link

No description provided.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there tests covering these functions? If not, perhaps we could add them?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there no tests? 😱

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, package/tests I had the same thought awhile ago. I'll dig into the tests a bit now and confirm there's coverage here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I should say, these changes were already in upstream, they'd just never been built.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there is an open PR on ember-model for this or that they have already been merged? If merged, any reason why we didn't branch off master?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They've been merged. We did branch off master.

They were merged without running grunt release so the changes are in the packages directory but not in the concated release file that we actually use through bower.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

👍

paddyobrien added a commit that referenced this pull request Oct 8, 2015
Remove dependence on Enumerable utils
@paddyobrien paddyobrien merged commit 022d324 into master Oct 8, 2015
@paddyobrien paddyobrien deleted the remove-enumerable-utils branch October 8, 2015 11:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants