added list all conversations endpoint #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can tests be added for these changes? |
kmossco
force-pushed
the
bv/add_list_conversations
branch
from
e503eaf to
ed745a1
Compare
Contributor
Author
|
@SeanSmithers added tests for both not sending the parameters, as well as not sending the right ones. 👍 |
khalilovcmd
reviewed
Jul 25, 2018
| !parameters.ContainsKey("sort") && | ||
| !parameters.ContainsKey("before")) | ||
| { | ||
| throw new ArgumentException(String.Format("'parameters' argument should include at least order, or sort, or before parameter.")); |
Contributor
There was a problem hiding this comment.
does it actually need to?
Contributor
Author
There was a problem hiding this comment.
Oh, you're right! I misread our docs 🤦♂️ Going to change that!
removed bug with params
kmossco
force-pushed
the
bv/add_list_conversations
branch
from
d441aea to
f7f9420
Compare
Contributor
Author
|
@khalilovcmd I removed that artificial limitation, now you can pass whatever parameters are useful. Can I get 👀on this again? |
khalilovcmd
approved these changes
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added a new endpoint that allows to list all conversations for an app, either without passing any parameters or by passing parameters. This closes #69
Added to the model the conversation rating model that was added to the API recently, and fixed a problem with loading conversation parts. This closes #113