Unable to tag contacts through the Java api

[blong824]

Version info

• intercom-java version: 2.2.6
• Java version: 1.8

Expected behavior

I am expecting to call Tag.tag(tag, contact); and be able to tag a contact through the java api.

Actual behavior

The java api only allows users or companies as the second parameter.

Steps to reproduce

1. Tag.tag(tag, contact) will not compile

[thewheat]

Thanks for raising this @blong824 ! 👍 You're correct that the current SDK doesn't support tagging by a Contact object right now but there is a workaround by creating a User object with the same ID as the Contact

From the docs https://developers.intercom.com/reference#tag-or-untag-users-companies-leads-contacts

Contacts/Leads can be tagged by supplying a users array. The array contains objects identifying leads by their id fields.

So something like that shown below will work

   // get a Tag object
   Tag tag = new Tag().setName("alliance");
   tag = Tag.create(tag);
    
   // get a Contact object and "convert" it to a User object
   Contact contact = Contact.findByID("5a8b7f19e0dd65126722b55c");
   User contactAsUser = new User();
   contactAsUser .setId(contact.getID());

   // Tag the contact via a User object
   Tag.tag(tag, contactAsUser);

A quick look at the code, to enable support for Contacts looks like we'd need to replicate these 2 user code blocks and add some tests

• intercom-java/intercom-java/src/main/java/io/intercom/api/Tag.java

  Lines 33 to 36 in f50c869

  	static Tag tag(Tag tag, UserCollection users) throws InvalidException, AuthorizationException {
  	TaggableCollection taggableCollection = createTagTypedCollection(tag, users);
  	return DataResource.create(taggableCollection, "tags", Tag.class);
  	}

• intercom-java/intercom-java/src/main/java/io/intercom/api/Tag.java

  Lines 66 to 98 in f50c869

  	@VisibleForTesting
  	static TaggableCollection createTagTypedCollection(Tag tag, UserCollection users) {
  	TaggableCollection taggableCollection = new TaggableCollection();
  	taggableCollection.setName(tag.getName());
  	taggableCollection.setId(tag.getId());
  	final List<Map<String, Object>> usersLite = Lists.newArrayList();
  	final List<User> pageItems = users.getPage();
  	for (User user : pageItems) {
  	Map<String, Object> userMap = Maps.newHashMap();
  	final String id = user.getId();
  	final String email = user.getEmail();
  	final String userId = user.getUserId();
  	if (user.isUntag()) {
  	userMap.put("untag", true);
  	}
  	if (!Strings.isNullOrEmpty(id)) {
  	userMap.put("id", id);
  	usersLite.add(userMap);
  	} else if (!Strings.isNullOrEmpty(email)) {
  	userMap.put("email", email);
  	usersLite.add(userMap);
  	} else if (!Strings.isNullOrEmpty(userId)) {
  	userMap.put("user_id", userId);
  	usersLite.add(userMap);
  	} else {
  	logger.warn("no identifiers found for user tag target, skipping [" + tag + "] [" + user.toString() + "]");
  	}
  	}
  	taggableCollection.setUsers(usersLite);
  	return taggableCollection;
  	}

Is that something you'd been keen on doing? 😄 If not, that isn't a problem and we can get to it 👍

[thewheat]

Just a heads up that I'll be working on making a PR for this enhancement this week

[thewheat]

PR created at #191 👍

[alkaphreak]

On which version does this PR is present ?
I got this problem today. (I'm in 2.2.12)