Skip to content

Remove unnecessary type validation #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
choran merged 1 commit into from
Dec 19, 2017
Merged

Remove unnecessary type validation #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions intercom-java/src/main/java/io/intercom/api/Conversation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,6 @@ static void validateMessageType(Reply reply) {
}

static void validateListRequest(Map<String, String> params) {
if (!params.containsKey("type")) {
throw new InvalidException("a user or admin type must be supplied for a conversation query");
}

if (isAdminQuery(params)
&& !(params.containsKey("admin_id"))) {
Expand Down