Skip to content

Conversation

@thewheat
Copy link
Contributor

@thewheat thewheat commented Jan 2, 2018

Addresses #162 for setting avatar on the user record.

Added feature to contacts/leads as well as tested in REST API and it is supported for them as well

@thewheat thewheat mentioned this pull request Jan 2, 2018
@choran
Copy link
Member

choran commented Jan 12, 2018

@thewheat I know we are missing some testing for other parts of the user resource in Java but there is some testing that we could use for this feature. e.g. here
Think we can add the avatar attribute here so we could have a test for it?
Does that make sense?

@thewheat
Copy link
Contributor Author

@choran Got it 👍 Will add as soon as possible 😄

@choran
Copy link
Member

choran commented Jan 19, 2018

Cool, I have merged in the other PRs but I can hold off on a release until you get this one updated.
That way we can release the three together
Cheers 👍

@thewheat thewheat force-pushed the timlim/add-avatar-update branch from 1b3cffd to f3f3cf9 Compare January 19, 2018 14:19
@thewheat thewheat force-pushed the timlim/add-avatar-update branch from f3f3cf9 to 4b877dd Compare January 19, 2018 14:38
@thewheat
Copy link
Contributor Author

@choran Tests added 👍

Copy link
Member

@choran choran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks, will do a new release tomorrow with these chances in it

@choran choran merged commit 158818f into master Jan 25, 2018
@thewheat thewheat deleted the timlim/add-avatar-update branch February 14, 2018 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants