Skip to content

Conversation

@SeanHealy33
Copy link
Contributor

Our Gradle version is super super old 😰

Currently our circle ci file pulls the most recent version of openJDK
https://github.com/intercom/intercom-java/blob/master/.circleci/config.yml#L5

our gradlew wrappers were generated over 4 years ago and do not support JDK 10.12 causing all our builds to fail seemingly randomly after a ReadMe.md commit.

This update should allow our ci to start building the project again.

@SeanHealy33 SeanHealy33 force-pushed the seanhealy/fixCIBuild branch 4 times, most recently from 7cfce3f to 1c79aa6 Compare August 7, 2018 14:30
@SeanHealy33 SeanHealy33 force-pushed the seanhealy/fixCIBuild branch from 1c79aa6 to 7dc5540 Compare August 7, 2018 14:35
@@ -1,25 +1,43 @@
#!/usr/bin/env bash
#!/usr/bin/env sh
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is auto generated from gradle wrapper

@SeanHealy33 SeanHealy33 requested a review from thewheat August 7, 2018 15:55
Copy link
Contributor

@thewheat thewheat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SeanHealy33 SeanHealy33 merged commit 7090a8a into master Aug 8, 2018
@SeanHealy33 SeanHealy33 deleted the seanhealy/fixCIBuild branch August 8, 2018 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants