Add support for marking conversation as read #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmartinic
reviewed
Oct 25, 2018
| @SuppressWarnings("UnusedDeclaration") | ||
| @JsonIgnoreProperties(ignoreUnknown = true) | ||
| @JsonInclude(JsonInclude.Include.NON_EMPTY) | ||
| public class ConversationRead extends TypedData { |
Contributor
There was a problem hiding this comment.
we can probably make this a private nested class in Conversation class so it's not exposed
thewheat
force-pushed
the
timlim/add-conversation-read
branch
from
8f28f30 to
aec966a
Compare
thewheat
force-pushed
the
timlim/add-conversation-read
branch
from
aec966a to
8f63dda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Current code does not support marking a conversation as read
How?
Add appropriate function all.
Unsure if having a
ConversationReadclass would be best here so open to feedback