Add support for conversation snoozing #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apassant
reviewed
Oct 25, 2018
| private boolean read; | ||
|
|
||
| @JsonProperty("state") | ||
| private String state; |
There was a problem hiding this comment.
What's that property used for in the context of snoozing? There's no setter, is that expected?
Contributor
There was a problem hiding this comment.
This maps to conversation state (open, closed, snoozed). We also have open )
which is boolean but that no longer fits with snoozed state.
https://developers.intercom.com/intercom-api-reference/reference#conversation-model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Snoozing and reading related attributes (
snoozed_untilandstate) are not currently supportedHow?
Added appropriate code to be able to snooze conversation and to read the conversation model for snooze attributes