Update webhook topics and add ping #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choran
reviewed
Nov 2, 2018
| subscription = Subscription.find("nsub_60ca7690-4020-11e4-b789-4961958e51bd"); | ||
|
|
||
| // ping a subscription | ||
| Subscription.ping("nsub_60ca7690-4020-11e4-b789-4961958e51bd"); |
Member
There was a problem hiding this comment.
Might be worth passing in a subscription object here rather than the ID itself. e.g
Subscription.delete(subscription) or
Subscription.update(subscription)
That way they could just use the return object after creating it
Contributor
Author
There was a problem hiding this comment.
Added support for Subscription.ping(subscription) 👍
thewheat
force-pushed
the
timlim/update-webhooks
branch
from
aa627da to
ac5b930
Compare
mmartinic
approved these changes
Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pingendpoint