Extract Iterator implementation into TypedDataCollection #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 31, 2018 08:19
…o TypedDataCollection so that all the collections can benefit from the iterator.
…es not call super() in its constructor.
Contributor
|
Wow @catacraciun that's great and thanks for the contribution! 😄 Thanks again! |
choran
approved these changes
Nov 2, 2018
Member
choran
left a comment
choran
left a comment
There was a problem hiding this comment.
👍 This seems really cool @catacraciun
Thanks alot for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
I am using ConversationPartCollection and it does not implement Iterator, as most of the Collections (in this SDK) do. Because of that, the code was looking pretty bad, as I couldn't use the TypedDataCollectionIterator either, as it is package-level. The solution to this is to make TypedDataCollection implement Iterator directly, and all its subclasses will benefit from it.
How?
First thing, TypedDataCollection now implements Iterator, it is delegating the hasNext(), next() and remove() methods to a TypedDataCollectionIterator instance. Second, I have removed all specific implementations of Iterator from all Collection classes, which were just copy-paste.