Skip to content

Conversation

@thewheat
Copy link
Contributor

@thewheat thewheat commented Nov 2, 2018

Why?

  • Current code just returns null for all DELETE requests
  • In PR 241 made an attempt to fix it but found that Tag.delete had an issue with the new code

How?

  • So now we check if DELETE response has data if it does proceed to process it as any other normal data
  • If there is no data just return null
  • Ran through all delete usage and all of them process and parse new code correctly
User.archive(Map<String, String> params)
User.archive(String id)
Contact.delete(String id)
Contact.deleteByUserID(String user_id)
Visitor.delete(Visitor v)
Visitor.delete(String id)
Tag.delete(String id)
Tag.delete(Tag tag) 
Subscription.delete(Subscription subscription)

@thewheat thewheat added the java label Nov 2, 2018
Copy link
Member

@choran choran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thewheat I would like to spend a little more time on this one since I think it could impact any delete in the API. I am just not sure at the moment so would like to hold off on this for now.

@thewheat
Copy link
Contributor Author

thewheat commented Nov 5, 2018

@choran Certainly understandable 👍

Copy link
Member

@choran choran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@choran choran merged commit c3ddbda into master Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants