404 error returned on getUser api call

[kahuwi]

Version info

• intercom-php version: 2.0.0
• PHP version: 5.6

Expected behavior

when user is not in intercom and getUser is called, the api should return with status with the user not found in the result

Actual behavior

api never returns, after further investigation guzzle dies on the 404 error returned by intercom api call. Page exists, has response code, but the http status of 404 causes guzzle to die.

Fatal error: Uncaught exception 'GuzzleHttp\Exception\ClientException' with message 'Client error: GET https://api.intercom.io/users?email=expiration%40test.com resulted in a 404 Not Found response: {"type":"error.list","request_id":"aomm6mt35nhsscst6fhg","errors":[{"code":"not_found","message":"User Not Found"}]} ' in /datadisk/vhosts/blueprintprep.com/myrest/vendor/guzzlehttp/guzzle/src/Exception/RequestException.php:107 Stack trace: #0 /datadisk/vhosts/blueprintprep.com/myrest/vendor/guzzlehttp/guzzle/src/Middleware.php(65): GuzzleHttp\Exception\RequestException::create(Object(GuzzleHttp\Psr7\Request), Object(GuzzleHttp\Psr7\Response)) #1 /datadisk/vhosts/blueprintprep.com/myrest/vendor/guzzlehttp/promises/src/Promise.php(203): GuzzleHttp\Middleware::GuzzleHttp{closure}(Object(GuzzleHttp\Psr7\Response)) #2 /datadisk/vhosts/blueprintprep.com/myrest/vendor/guzzlehttp/promises/src/Promise.php(156): GuzzleHttp\Promise\Promise::callHandler(1, Object(GuzzleHttp\Psr7\Response), Array) #3 /datadisk/vhosts/blueprintprep.co in /datadisk/vhosts/blueprintprep.com/myrest/vendor/guzzlehttp/guzzle/src/Exception/RequestException.php on line 107

Steps to reproduce (as granular as possible, including screenshots where appropriate)

1. use this code:

require_once 'vendor/autoload.php';
use Intercom\IntercomClient;
$client = new IntercomClient('YOUR TOKEN GOES HERE',null);
echo 'Client Defined<br>';
$user = $client->users->getUsers(["email" => "bogus@noserver.com"]);
echo $user->id;
echo '<br>';
$delete_user = $user->id;
echo $user->name;
echo '<br>';
$client->users->deleteUser($delete_user);

2. Run code from 1 and you will see the Client Defined, and the error. However none of the other echo are seen since the getUsers call never returned.

3. Intercom is overloading the 404 to mean user not found. The page is found and has the proper response data to indicate user not found. However, since the http status is 404 and guzzle sees as a page not found guzzle errors out. Intercom needs to return 200 or intercom api needs to handle the 404 and return the response back up the line so I can handle it in my codebase.

Logs

[travega]

@Skaelv @mmartinic ^

[kahuwi]

Been over a month on my issue, Is there any status?
Thanks,
Karl

[kant01ne]

@kahuwi Thanks for bringing this up and sorry for the delay in our answer.

You can catch Guzzle Exceptions in your code if you don't want to throw exceptions when a user is not found.
We are not going to modify our API status code neither are we going to make breaking change in the SDK (more context on #198).

I'm adding a section in the readme to explain how to catch exceptions from Guzzle properly.

[kahuwi]

Bottom line in this our response is that instead of you the provider I the consumer have to add code to detect bad behavior within your api. This is unacceptable. You are violating the web standards with your API behavior. Your php API call never returns, if it came back I could catch it and deal with the off standard error return. Maybe you can give a way when making a web call via your API that allows me to handle it?

[kant01ne]

Returning 404 when a resource is not found is a standard in REST APIs.

As discussed in #198 catching the exception on your end is probably the best way for you to handle the User not found Exception. Even if we had merged #198 (which would have been a breaking change) you would have had to handle the response with an if/else statement.

[kahuwi]

Resource is if page is not found, not a piece of information contained within.

…

Sent from my iPhone

On Feb 11, 2017, at 4:44 PM, Kevin Antoine ***@***.***> wrote: Returning 404 when a resource is not found is a standard in REST APIs. As discussed in #198 catching the exception on your end is probably the best way for you to handle the User not found Exception. Even if we had merged #198 (which would have been a breaking change) you would have had to handle the response with an if/else statement. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[kahuwi]

https://en.m.wikipedia.org/wiki/HTTP_404 Unable to communicate with server is NOT indicating that I got to the server and a user is not found. Especially since you actually have the user not found info in the return data. You setting this to a 404 is seen by anyone who knows how a 404 is to be used sees this error as the server is not working. Your own API dumps when the 404 is seen. So fix your php API to return back the user not found then all will be fine. If you had already properly used 404 then all would have worked as is. You really need to fix this behavior. Sent from my iPhone

…

On Feb 11, 2017, at 4:44 PM, Kevin Antoine ***@***.***> wrote: Returning 404 when a resource is not found is a standard in REST APIs. As discussed in #198 catching the exception on your end is probably the best way for you to handle the User not found Exception. Even if we had merged #198 (which would have been a breaking change) you would have had to handle the response with an if/else statement. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[atlkuk]

Hi, I have the same issue, even if the user exists in my intercom users list. The code is:

require 'intercom/vendor/autoload.php';

use Intercom\IntercomClient;

$client = new IntercomClient(INTERCOM_APP_ID, INTERCOM_APP_SECRET);

$user = $client->users->getUsers(["user_id" => ID]);

I tried with email too but the method doesn't return any user

is there a possible solution?

Thanks

[kahuwi]

If you send an intercom getUsers call to a non-existent user they use 404 causing their php api to blow up. What you need to do is try{}catch{} the get user call so that the 404 will then be seen in your php client. simple example:
try {
$user = $client->users->getUsers(["email" => "test@test.com"]);
$return_data['data']['user_id'] = $user->id;
$return_data['data']['user_name'] = $user->name;
} catch (Exception $e) {
print_r(get_class_methods($e));
$error_code = $e->getCode();
if ($error_code == 404):
echo "ERROR : " . $error_code;
else:
endif;
$return_data['data']['error'] = $error_code . ' - User Not Found';
$return_data['data']['user_id'] = 0;
}
This concept works for me.

[kahuwi]

One other thing:
My code excerpt previously is in a class method that has the following:

require_once 'vendor/autoload.php';
use Intercom\IntercomClient;

class Intercom_Model 
{
	var $intercom;

function __construct() {
$this->intercom = new IntercomClient('YOUR API KEY',null);
}// end of constructor

function test(){
// code from previous comment
} // end of test

} // end of class

make sure you are using the new API as intercom has changed KEY use in the API
Sorry that I forgot this info earlier

[atlkuk]

Thanks for the reply, but i don't understand why it returns me a 404 error even if the user exists, i'm sure of that because I see it in my users list

[kahuwi]

If you run the above and are getting a 404, double check your getUsers parameter and use email and not the ID. In the catch the print_r will lay it all out and you can see what Intercom is returning if all looks good, then you will need to chat into developer.intercom.io and talk to them.

[atlkuk]

ok thx, I'll try :)