Skip to content

fix: SMPClient context logs formatted traceback, not repr #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JPHutchins merged 1 commit into from
May 17, 2025
Merged

fix: SMPClient context logs formatted traceback, not repr #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions smpclient/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@

import asyncio
import logging
import traceback
from hashlib import sha256
from types import TracebackType
from typing import AsyncIterator, Final, Tuple, Type
Expand Down Expand Up @@ -401,10 +402,10 @@ async def __aexit__(
self,
exc_type: Type[BaseException] | None,
exc_value: BaseException | None,
traceback: TracebackType | None,
tb: TracebackType | None,
) -> None:
if exc_value is not None:
logger.error(f"Exception in SMPClient: {exc_type=}, {exc_value=}, {traceback=}")
logger.error(f"Exception in SMPClient:\n{traceback.format_exc()}")
await self.disconnect()

@staticmethod
Expand Down
Loading