BREAKING: drop Python 3.8 support; update poetry and lock#68
Merged
JPHutchins merged 1 commit intomainfrom May 31, 2025
Merged
Conversation
JPHutchins
requested review from
aldenhaase,
Copilot,
davedesro,
klam20,
robhelvestine and
swoisz
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR drops Python 3.8 support and updates project tooling by migrating to the new PEP 621 project metadata format, along with integrating poetry-dynamic-versioning and updating CI workflows.
- Removed Python 3.8‑specific compatibility code from tests
- Updated pyproject.toml to use PEP 621 and dynamic versioning
- Adjusted CI workflows (test, docs, release, lint) and documentation to target supported Python versions and newer Poetry commands
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_base64.py | Removed obsolete type ignores related to Python 3.8 compatibility |
| pyproject.toml | Migrated metadata to new format and integrated dynamic versioning |
| README.md | Updated Poetry installation instructions |
| .github/workflows/test.yaml | Revised Python version matrix and Poetry commands for testing |
| .github/workflows/test-docs.yaml | Updated Poetry installation command for documentation testing |
| .github/workflows/release.yaml | Adjusted Poetry commands and action versions for release workflow |
| .github/workflows/lint.yaml | Revised Python version matrix and injection of Poetry dynamic details |
Collaborator
Author
|
Closes #63 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bleak dropped python 3.8 support, so we're following. It is only a breaking change for downstream projects using python 3.8. Otherwise, updating to poetry 2 and poetry-dynamic-versioning, plus fixing the PyPI flow.