smpclient: mcuboot: treat all files as binary except for .hex#74
Merged
JPHutchins merged 2 commits intointercreate:mainfrom Aug 25, 2025
Merged
smpclient: mcuboot: treat all files as binary except for .hex#74JPHutchins merged 2 commits intointercreate:mainfrom
JPHutchins merged 2 commits intointercreate:mainfrom
Conversation
JPHutchins
requested review from
JPHutchins,
JerryCapistrano,
KungFuSensai,
aldenhaase,
Copilot,
davedesro,
klam20,
robhelvestine and
swoisz
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes file extension restrictions in the MCUBoot image loading functionality, treating all files as binary except for .hex files. This makes the library more generic by removing artificial limitations on supported file extensions.
- Removes the validation that only accepts .bin and .hex file extensions
- Changes the logic to treat all files except .hex as binary files
- Simplifies the file loading logic by removing unnecessary restrictions
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove limitations on file extensions and treat all of them as binary except for .hex.
This type of self-imposed limitation IMHO belongs in end-user tools where it might have some sort of use (e.g. platform-specific binaries generated by other tools), but not in a generic library like this.