Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates project dependencies and Python version support, removing support for Python 3.8 and adding support for Python 3.14. The main changes involve updating the bleak and smp packages to newer major versions and adjusting test mocks accordingly.
- Updated dependency versions for
bleak(0.22.1 → 1.1.1) andsmp(3.1.1 → 4.0.0) - Extended Python support to include 3.14 while dropping 3.8 support
- Modified test mocks to accommodate API changes in the updated
bleaklibrary
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_smp_ble_transport.py | Updated BLEDevice mock constructor calls to remove RSSI parameter |
| pyproject.toml | Updated dependency versions, Python version constraints, and configuration |
| .github/workflows/test.yaml | Added Python 3.14 to test matrix |
| .github/workflows/lint.yaml | Added Python 3.14 to lint matrix |
| .flake8 | Added .poetry to exclude list |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This was
linked to
issues
Oct 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.